Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delivery select style #1920

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix delivery select style #1920

wants to merge 3 commits into from

Conversation

Pierre-LHOSTE
Copy link
Contributor

@Pierre-LHOSTE Pierre-LHOSTE commented Nov 20, 2024 •
edited
Loading

Fix the misalignment and the bug in the dark mode of the AddressAutocomplete

#1913 (comment)
#1913 (comment)

@Pierre-LHOSTE Pierre-LHOSTE changed the title Use color hook Fix delivery select style Nov 20, 2024
@Pierre-LHOSTE Pierre-LHOSTE marked this pull request as ready for review December 30, 2024 19:45
@vladimir-8 vladimir-8 requested a review from r0xsh January 6, 2025 16:37
r0xsh
r0xsh approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@r0xsh r0xsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is fine, the behavior work as expected 👍
UI side a small fix may be needed on the other screens using the autocomplete field
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0xsh r0xsh r0xsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pierre-LHOSTE @r0xsh