Map picker modal #1969
Open
Map picker modal #1969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0xsh
commented
Mar 27, 2025
| _.includes(component.types, 'country'), | ||
| ); | ||
| let adminArea1 = _.find(geocodingResult.address_components, component => | ||
| _.includes(component.types, 'administrative_area_level_1'), |
There was a problem hiding this comment.
administrative_area_level_1 is related to the Plus Codes
|
I've used Prettier to format my source files, so it end up editing some indentations and white spaces. You can easily avoid diffing those by enabling this feature inside GH |
Was not able to make `useCallback` work so i switch to `useMemo` that should do the same job
|
|
@alexsegura please review on iOS |
|
@r0xsh we get these conflicts now because the files got renamed to typescript in #2021. One option to resolve them might be:
or maybe the git client that you are using will manage it on its own Let me know if you have any questions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
output.mp4