Add price override in react delivery form #4860
Conversation
```javascript
fetch('/api/task?groups=task,address,barcode')
.then((response) => response.json())
.then((data) => console.log(data));
```
…/coopcycle/coopcycle-web into feat/deliveryform-override-price
Atala
changed the title
# Conflicts: # src/Entity/Store.php
| @@ -49,11 +49,16 @@ final class TaxRate | |||
|
|
|||
| public function __construct(BaseTaxRate $taxRate, string $name, array $alternatives = []) | |||
| { | |||
| var_dump($taxRate->getCode()); | |||
| * @var DeliveryPriceInput | ||
| * @Groups({"delivery_create"}) | ||
| */ | ||
| private $deliveryPriceInput; |
There was a problem hiding this comment.
AFAIK there is no need to create a new DeliveryPriceInput for this, you can use the existing ArbitraryPrice.
This way in Appbundle\Action\Delivery\Create, you don't need to convert the DeliveryPriceInput into an ArbitraryPrice. Just put the @var ArbitraryPrice and/or add type hinting, and API Platform will understand.
| $arbitraryPrice = new ArbitraryPrice( | ||
| $data->getDeliveryPriceInput()->getVariantName(), | ||
| $data->getDeliveryPriceInput()->getPriceIncVATcents() | ||
| ); |
There was a problem hiding this comment.
See other comment, you could avoid doing this conversion by using ArbitraryPrice for serialization.
| @@ -26,7 +28,20 @@ public function __invoke(Delivery $data) | |||
| throw new ValidationException($errors); | |||
| } | |||
|
|
|||
| $this->pricingManager->createOrder($data); | |||
| $useArbitraryPrice = $this->authorizationCheckerInterface->isGranted('ROLE_ADMIN') && !is_null($data->getDeliveryPriceInput()); | |||
There was a problem hiding this comment.
If you use ArbitraryPrice in Delivery class, !is_null($data->getDeliveryPriceInput()) could be replaced by a more expressive & positive method name, hasArbitraryPrice().
| "deliveryPriceInput": { | ||
| "priceIncVATcents": 1200, | ||
| "variantName": "my custom variant" | ||
| } |
There was a problem hiding this comment.
This does not belong here. To test that the order has been created, yes you should target the orders API.
Eventually, you can return an IRI corresponding to the created order:
"order": "/api/orders/1"
| "deliveryPrice": { | ||
| "variantName": "my custom variant", | ||
| "value": 1200, | ||
| "@*@": "@*@" | ||
| }, |
There was a problem hiding this comment.
You don't need this, you just need to check the value of total
There was a problem hiding this comment.
i wanted to check the variant name, how can i do that without this call? (+ I need the variant name when editing the delivery)
There was a problem hiding this comment.
add the field in OrderItemNormalizer
#4851
#4848
#4853
#4854
#4856