Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create batch_queue_flux stub #3978

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dblitt
Copy link
Contributor

@dblitt dblitt commented Nov 12, 2024

Proposed Changes

This PR creates a stub batch_queue module for the Flux Framework. I will be working in the immediate future to implement the submit, wait, and remove functionality of this module so Makeflow and vine_factory will be able to natively submit jobs to a flux instance. batch_queue_flux is currently marked as experimental.

I also have fixed some out of date documentation in batch_queue.h

Merge Checklist

The following items must be completed before PRs can be merge.
Check these off to verify you have completed all steps.

  • make test Run local tests prior to pushing.
  • make format Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)
  • make lint Run lint on source code prior to pushing.
  • Manual Update Update the manual to reflect user-visible changes.
  • Type Labels Select a github label for the type: bugfix, enhancement, etc.
  • Product Labels Select a github label for the product: TaskVine, Makeflow, etc.
  • PR RTM Mark your PR as ready to merge.

@tphung3
Copy link
Contributor

tphung3 commented Nov 13, 2024

Ok, this is a good template for further work. I think you know Flux enough by now to implement batch_queue_flux_submit and batch_queue_flux_remove. Don't worry about supporting all features, and instead try to submit basic Linux commands to flux and remove them using above APIs. To test your work you can write a custom test script calling batch_queue_flux_submit and batch_queue_flux_remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants