Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vine: check if file exists on worker when access file_replica_table #4060

Merged

Conversation

JinZhou5042
Copy link
Member

@JinZhou5042 JinZhou5042 commented Feb 11, 2025

Proposed Changes

It’s easy to accidentally add a file to a worker twice using vine_file_replica_table_insert.

If the file already exists on the worker, we should avoid incrementing w->inuse_cache.

This causes inconsistence between the worker's actual cache inuse and the manager's record.

Merge Checklist

The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.

  • make test Run local tests prior to pushing.
  • make format Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)
  • make lint Run lint on source code prior to pushing.
  • Manual Update: Update the manual to reflect user-visible changes.
  • Type Labels: Select a github label for the type: bugfix, enhancement, etc.
  • Product Labels: Select a github label for the product: TaskVine, Makeflow, etc.
  • PR RTM: Mark your PR as ready to merge.

@dthain dthain merged commit 086764b into cooperative-computing-lab:master Feb 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants