Open
Conversation
ikruglov
suggested changes
Feb 26, 2026
Comment on lines
+66
to
68
| pub fn value_as_string(&self) -> Option<&str> { | ||
| self.value.as_str() | ||
| } |
Contributor
There was a problem hiding this comment.
still, value is a mandatory field in a metric. I think you should be able to remove Option<>. Maybe you can validate metric structure before parsing it
Comment on lines
+192
to
+193
| crate::units::update_unit_stats(config_clone, sdc_clone, stats_clone) | ||
| .await |
Contributor
There was a problem hiding this comment.
you calling crate::units::update_unit_stats here and a couple of lines below. Maybe merge them.
pseudo code:
if (varlink_enabled) {
call_varlink()
if success
return
log("Fallback to DBus")
}
call_dbus()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses @ikruglov's comments on #158.