run release only if build/test succeeds

another goreleaser fix
coopernetes · Feb 21, 2023 · 52878b9 · 52878b9
1 parent ddda406
commit 52878b9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -3,8 +3,12 @@ on:
   push:
     tags:
       - "v*"
+  workflow_run:
+    workflows: [build/test]
+    types: [completed]
 jobs:
   goreleaser:
+    if: ${{ github.event.workflow_run.conclusion == 'success' }}
     runs-on: ubuntu-latest
     steps:
       -

diff --git a/.goreleaser.yml b/.goreleaser.yml
@@ -8,7 +8,7 @@ before:
     - go generate ./...
 builds:
   - main: ./cmd/kube-role-gen/
-  - env:
+    env:
       - CGO_ENABLED=0
     goos:
       - linux

diff --git a/Makefile b/Makefile
@@ -28,7 +28,7 @@ build: $(TARGET)
 test:
 	go test ./...
 
-e2e: test
+e2e:
 	tests/e2e_tests.sh
 
 clean: