-
Notifications
You must be signed in to change notification settings - Fork 3
Move llm-history out of electron-store config.json #993
Copy link
Copy link
Closed
Labels
area:performancePerformance, resource usage, and package sizePerformance, resource usage, and package sizearea:storagePersistence, threads, memories, and migrationPersistence, threads, memories, and migrationbugSomething isn't workingSomething isn't workingperformancePerformance / CPU / memory issuePerformance / CPU / memory issuepriority:p2Important issue to address soonImportant issue to address soon
Milestone
Description
Activity
Metadata
Metadata
Assignees
Labels
area:performancePerformance, resource usage, and package sizePerformance, resource usage, and package sizearea:storagePersistence, threads, memories, and migrationPersistence, threads, memories, and migrationbugSomething isn't workingSomething isn't workingperformancePerformance / CPU / memory issuePerformance / CPU / memory issuepriority:p2Important issue to address soonImportant issue to address soon
Observed during the startup-hang investigation (#988): a real profile's config.json had grown to 21.5 MB, almost entirely
llm-history:*entries. electron-store parses the whole file per.get(now mitigated by the in-memory cache) and rewrites the whole file on every.set— so every agent turn serializes 21 MB to disk, and the file grows without bound.Chat history belongs in the filesystem thread store (per-thread files), not a monolithic JSON config. Migrate
llm-history:*out, with a one-time import like the #644 thread migration. Consider a startup warning/telemetry when config.json exceeds a few MB so silent aging is visible.