Skip to content

fix(deps): override adm-zip to ^0.6.0 to clear the npm audit CI gate - #1014

Merged
jonathanKingston merged 1 commit into
mainfrom
claude/merge-low-risk-prs-hot6yl
Jul 18, 2026
Merged

jonathanKingston merged 1 commit into
mainfrom
claude/merge-low-risk-prs-hot6yl

Conversation

@jonathanKingston

@jonathanKingston jonathanKingston commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

The npm audit --audit-level=high precheck gate (landed with #903) is failing on main itself: GHSA-xcpc-8h2w-3j85adm-zip@0.5.18 pulled in via onnxruntime-node@huggingface/transformers. Because the gate runs inside precheck, every open PR's CI is currently red, and all armed auto-merges are stuck behind it.

Change

Add "adm-zip": "^0.6.0" to the existing overrides block in package.json (alongside dompurify/serialize-javascript/tar) and refresh package-lock.json. This is the advisory's patched line; 0.6.0 keeps the same API surface onnxruntime-node uses for archive extraction.

Verified locally: npm ls adm-zip shows 0.6.0 overridden and npm audit --audit-level=high exits 0 with "found 0 vulnerabilities".

After merge

Open PRs need their branches updated (or CI re-run) to pick the fix up through the merge ref — their prechecks will keep failing until then.

🤖 Generated with Claude Code

https://claude.ai/code/session_01KTABxrmLvrGWZe4JgDh8YC


Generated by Claude Code


Note

Low Risk
Dependency-only override with no application code changes; risk is limited to zip extraction behavior in optional ONNX/transformers paths, which the PR author expects to remain API-compatible.

Overview
Adds an adm-zip ^0.6.0 npm override next to the existing security overrides so the lockfile no longer resolves the vulnerable 0.5.18 copy pulled in transitively (e.g. onnxruntime-node under optional @huggingface/transformers). package-lock.json is refreshed to 0.6.0 (Node engine >=14.0 on that package).

This targets GHSA-xcpc-8h2w-3j85 so npm audit --audit-level=high in CI can pass again; branches that predate the fix need a merge or re-run to pick it up.

Reviewed by Cursor Bugbot for commit 5b26747. Bugbot is set up for automated code reviews on this repo. Configure here.

The npm audit --audit-level=high precheck gate (landed in #903) fails
on GHSA-xcpc-8h2w-3j85: adm-zip <0.6.0 via onnxruntime-node via
@huggingface/transformers, turning CI red for every PR. Force the
patched adm-zip through the existing overrides block.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KTABxrmLvrGWZe4JgDh8YC
@jonathanKingston
jonathanKingston enabled auto-merge (squash) July 18, 2026 15:45
@cursor

cursor Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_b234fc0f-3d96-419a-ac7a-cfeed9410580)

@cursor
cursor Bot requested a review from AutomatedTester July 18, 2026 15:46

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not approve: Cursor Bugbot skipped (usage limit reached) and did not complete its review. Human review is needed for this dependency override; requested AutomatedTester as reviewer.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@jonathanKingston
jonathanKingston merged commit d6e045a into main Jul 18, 2026
20 checks passed
@jonathanKingston
jonathanKingston deleted the claude/merge-low-risk-prs-hot6yl branch July 18, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants