fix(ci): resolve reconcile-screenshots PR probe with curl+jq - #1053
Merged
Merged
Conversation
CHECKS_RUNNER images ship curl+jq but not the gh CLI. The open-PR gate in reconcile-screenshots.yml still called `gh api`, so every matrix cell failed with exit 127 (`gh: command not found`) on screenshot-churn main pushes. Mirror the #1031 REST lookup and fail closed on transport/API errors. Co-authored-by: Jonathan Kingston <jonathanKingston@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main tip
f3741723check suite failed threereconcile (N, branch)jobs (970 / 978 / 989) with exit 127.Root cause
.github/workflows/reconcile-screenshots.ymlruns on${{ vars.CHECKS_RUNNER }}. Those self-hosted images shipcurl+jqbut not the GitHub CLI (ci-runners/Dockerfile). The "Check pull request is still open" step still calledgh api, so every matrix cell failed immediately withgh: command not found.Same tool gap #1031 fixed for
ci-passed/commit-screenshotsinci.yml.Fix
Replace the
gh api … --jq .stateprobe withcurl+jqagainstgithub.api_url, and fail closed on transport/API errors (do not treat a failed lookup as a closed PR).Validation
state=open.npm run checkgreen (3604 unit tests).Trigger
f3741723