Skip to content

chore(e2e): review screenshots for #2383 - #2390

Closed
copse-release-bot[bot] wants to merge 2 commits into
copse/something-went-wrong-in-another-copse-thre-d07699from
screenshots/pr-2383/0263e6676aa5
Closed

chore(e2e): review screenshots for #2383#2390
copse-release-bot[bot] wants to merge 2 commits into
copse/something-went-wrong-in-another-copse-thre-d07699from
screenshots/pr-2383/0263e6676aa5

Conversation

@copse-release-bot

Copy link
Copy Markdown
Contributor

Screenshot candidates rendered for parent PR
#2383 at
0263e6676aa5fceabdfd39477db3afb07066ae2f by
CI run 33996943129.

Review GitHub's image diffs, then merge this PR (or enable auto-merge) to apply the
accepted references to copse/something-went-wrong-in-another-copse-thre-d07699. This branch contains
only PNG candidates from the immutable
reference-screenshot-candidates-33996943129 artifact and never targets main.

If the parent branch has advanced beyond the source SHA above, do not merge this PR;
the successful CI run for the new head will replace it.

jonathanKingston and others added 2 commits September 5, 2026 23:48
Add an explicit macOS permission for the native git_commit subprocess to reach the configured SSH agent socket while preserving the existing filesystem and network sandbox. Supply path-configured signing keys as inline public identities, and patch sandbox-runtime so per-spawn Unix socket allowances reach the seatbelt profile.

Co-Authored-By: Copse <noreply@copse.dev>
Copse-Models: acp:codex-acp#gpt-5.6-sol
@jonathanKingston

Copy link
Copy Markdown
Collaborator

Do not merge this screenshot candidate. #2383 already commits its one focused visual reference, git-commit-signing-permission.png, and that screenshot is readable. This generated PR does not touch it; it changes 28 unrelated baselines across browser, settings, worktree, transcript, theme, and tool-display surfaces. Treat this as capture/baseline churn.

github-actions Bot added a commit that referenced this pull request Sep 5, 2026
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

🖥️ PR preview

@jonathanKingston
jonathanKingston force-pushed the copse/something-went-wrong-in-another-copse-thre-d07699 branch from 0263e66 to b4cf0af Compare September 6, 2026 09:19

Copy link
Copy Markdown
Collaborator

Closing: these candidates predate #2398, which pinned every reference capture at a 2x device-pixel ratio. All 28 PNGs here were rendered at 1x, so merging this would push 1x baselines back onto copse/something-went-wrong-in-another-copse-thre-d07699 and undo the normalization on main.

Parent #2383 has been rebased onto current main, so its head has moved past the 0263e6676aa5 this branch is pinned to. CI on the new head re-renders the references at the pinned 2x and publishes a fresh review PR.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant