Fix Codex ACP startup failures stuck as running tools - #2698
Merged
Merged
Conversation
Contributor
Contributor
Reference screenshots ready for reviewReview GitHub’s image diffs in screenshot PR #2707. Rendered for If this source branch moves, a later successful render closes the stale review PR and replaces this link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex ACP reports an MCP startup failure as a single
tool_callcarryingstatus: failedand its diagnostic. Copse discarded that initial state and waited for a later update that never arrives, leaving identical “Startup” rows spinning indefinitely.Preserve initial tool output and terminal status by emitting the creation followed by the existing update path. Keep the MCP server name in startup labels, so failures appear as
docs startuporissue_tracker startupwith their original diagnostics.Closes #2494.
Validation:
pnpm run buildpassed.hook-cards(wait timeout),mermaid-parity(SVG geometry),pane-loading(loading UI assertion), andstaged-diff-ui(timeouts/missing proposed section).pnpm run check: all static gates passed; 9,267 of 9,296 unit tests passed. The 29 failures hit deadlines in unchanged hook suites (after-file-edit,before-submit-prompt,diff-apply,permission-decision,post-turn-review,session-start,stop, andsubagent).GitHub CI is currently blocked in precheck:
pnpm audit --audit-level=highreports GHSA-7q85-xj36-vmfc for the existingadm-zip@0.6.0dependency through Rampart → Transformers → onnxruntime-node. The dependency manifest and lockfile are identical tomain.