Fix Inspect Element in browser context menu - #2699
Merged
jonathanKingston merged 3 commits intoSep 20, 2026
Merged
jonathanKingston merged 3 commits into
jonathanKingston merged 3 commits into
Conversation
Co-Authored-By: Copse <noreply@copse.dev> Copse-Models: acp:codex-acp#gpt-6
Contributor
Contributor
Reference screenshotsCI run 35514033579 published no changed screenshot candidates for |
Screenshot candidates rendered for parent PR #2699 at `9b58320abc2b61e8e445532d1fd47eec92c6c59a` by [CI run 35476145819](https://github.com/copse-dev/agent-pane/actions/runs/35476145819). Review GitHub's image diffs, then merge this PR (or enable auto-merge) to apply the accepted references to `copse/how-come-right-click-inspect-element-isn-t-93b136`. This branch contains only PNG candidates from the immutable `reference-screenshot-candidates-35476145819` artifact and never targets `main`. If the parent branch has advanced beyond the source SHA above, do not merge this PR; the successful CI run for the new head will replace it. Co-authored-by: jonathanKingston <338988+jonathanKingston@users.noreply.github.com>
jonathanKingston
deleted the
copse/how-come-right-click-inspect-element-isn-t-93b136
branch
September 20, 2026 13:49
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Right-click Inspect Element in a browser guest now waits for Electron's native context menu to close, opens detached guest DevTools, and targets the clicked coordinates after DevTools reports that it is ready. The popup is also associated with its owner window, frame, and source type.
Unit coverage verifies the native-menu ordering, the already-open DevTools path, cancellation, and guest destruction while DevTools opens.
Validation
corepack pnpm test -- src/main/windows/browser-context-menu.test.ts— 12 passedcorepack pnpm test -- src/main/services/hooks/after-file-edit.test.ts— 10 passedcorepack pnpm run typecheckcorepack pnpm run lintcorepack pnpm run format:checkcorepack pnpm run demo:site:checkcorepack pnpm run check:dead-codecorepack pnpm run check:oraclecorepack pnpm run check:e2e-syntaxcorepack pnpm run buildgit diff --checkThe first broad unit run completed with 27 hook subprocess cases timing out at their two-second limit under full-suite load. The representative hook file passes all 10 cases in isolation.
Visual evidence
No screenshot is included. Electron's native context menu is outside renderer screenshots, and the ChromeDriver debugger suppresses guest DevTools in this fixture, including the existing toolbar Open inspector path. The native ordering is covered deterministically by the focused unit test.
Co-Authored-By: Copse noreply@copse.dev
Copse-Models: acp:codex-acp#gpt-5.6-sol