Skip to content

Render thread references inline in the composer - #2978

Merged
jonathanKingston merged 2 commits into
mainfrom
copse/whenever-i-a-thread-it-should-be-shown-inl-bb9aac
Sep 22, 2026
Merged

jonathanKingston merged 2 commits into
mainfrom
copse/whenever-i-a-thread-it-should-be-shown-inl-bb9aac

Conversation

@jonathanKingston

Copy link
Copy Markdown
Collaborator

Summary

  • insert selected @thread references as atomic inline composer chips at the caret
  • reuse Copse's existing thread and close SVGs plus the sent-thread outline geometry
  • preserve chip position through draft switches and render it inline after send
  • keep thread labels in agent-facing prose while retaining the structured thread reference
  • add focused unit, browser-geometry, Electron E2E, screenshot, and prototype coverage

Validation

  • pnpm run typecheck — passed after rebasing onto current origin/main
  • pnpm run lint — passed
  • pnpm run format:check — passed
  • pnpm test -- composer-editor conversation-transcript input-bar modern-css — 101 passed
  • pnpm run build:demo — passed
  • pnpm exec wdio run wdio.demo.conf.ts --spec tests/demo/thread-reference-inline.demo.ts — passed in real Chrome; verifies matching outline tokens, baseline alignment, icon centering, and stationary hover
  • static check phases for demo consistency, dead code, oracle invariants, E2E syntax, and E2E exclusions — passed
  • focused Electron E2E is authored and syntax-clean, but was not run locally: the local launcher was rejected by the safety gate and no configured remote E2E destination was available
  • the monolithic full unit tier exceeded the tool's five-minute foreground ceiling; its sandbox attempt exposed only five loopback preview-server EPERM failures, so hosted CI remains the full-tier authority

Visual evidence

  • tests/e2e/screenshots/thread-reference-inline-composer.png

Co-Authored-By: Copse noreply@copse.dev
Copse-Models: acp:codex-acp#gpt-5.6-sol, acp:claude-acp#claude-fable-5-1[1m]

@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Screenshot evidence

Changed reference candidates for 38efdc22e5b8 are in the screenshot artifact from CI run 35773612051.
The artifact is retained for 14 days; its presence does not mean the visual changes have been accepted.

Review this evidence with the parent PR. No baseline-update PR was opened.
If the references should change, add update-screenshots to run a full refresh and open a PNG review PR, or commit the reviewed PNGs manually. Remove the label once the review PR is created.
Do not refresh references merely to absorb unrelated rendering drift.

jonathanKingston and others added 2 commits September 22, 2026 20:18
Insert @thread selections as atomic composer chips, preserve their sentence position through drafts and sent transcripts, and add focused browser geometry evidence.
@jonathanKingston
jonathanKingston force-pushed the copse/whenever-i-a-thread-it-should-be-shown-inl-bb9aac branch from 5172a4b to 38efdc2 Compare September 22, 2026 19:24
github-actions Bot added a commit that referenced this pull request Sep 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

@jonathanKingston
jonathanKingston merged commit e72c127 into main Sep 22, 2026
24 checks passed
@jonathanKingston
jonathanKingston deleted the copse/whenever-i-a-thread-it-should-be-shown-inl-bb9aac branch September 22, 2026 19:57
github-actions Bot added a commit that referenced this pull request Sep 22, 2026

This branch was successfully deployed

1 active deployment
github-pages 38efdc22 Deployed Sep 22, 2026 by jonathanKingston via deploy / deploy #1247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant