Skip to content

Post an "all screenshots match" note instead of gating the comment step - #839

Merged
jonathanKingston merged 3 commits into
mainfrom
claude/screenshot-matching-response-uwqw3d
Jul 18, 2026
Merged

jonathanKingston merged 3 commits into
mainfrom
claude/screenshot-matching-response-uwqw3d

Conversation

@jonathanKingston

@jonathanKingston jonathanKingston commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Recovered from the previously-unmerged branch claude/screenshot-matching-response-uwqw3d (no PR had been opened), rebased onto current main.

What

Reworks the "Comment on PR with updated screenshots" step so it always runs: posts an "All screenshots match" note when nothing re-rendered (flipping a stale comment), no-ops when there's nothing to report and no prior comment, and tidies the "ignored as render noise" wording.

Notes

  • Opened as draft — low-value UX polish; close if not wanted.
  • ⚠️ Overlaps with Don't hard-fail screenshot reconcile when main advances a workflow file #838 (screenshots-merge-issue): both edit the same ci.yml "Comment on PR" step, so whichever merges second will need a small re-resolve.
  • Rebase resolution removed main's if: gate on that step (the branch's intended change, required for the all-match note to fire) while keeping main's newer @v9 and flapping/contested sections. YAML validates.

🤖 Generated with Claude Code


Generated by Claude Code


Note

Low Risk
Workflow-only UX for PR comments; no application code or merge-gate logic changes beyond when the comment posts.

Overview
The commit-screenshots job’s PR comment step now runs whenever the head branch still exists, instead of only when there were commits, ignored noise, flapping/contested holds, or merge conflicts.

When a run has nothing to report, the script either updates an existing bot comment to say all screenshots match (clearing stale “held/refreshed” text) or does nothing if there was never a comment—so clean PRs don’t get a new thread every CI pass. The ignored as render noise section is shortened to a count and instructions, without listing each file.

Reviewed by Cursor Bugbot for commit 48bbb7f. Bugbot is set up for automated code reviews on this repo. Configure here.

The e2e screenshot comment listed each ignored shot with pixel counts;
drop the per-file list and just report the count. Also post an
"All screenshots match" summary when a run has nothing to report and a
prior comment exists (flipping a resolved thread), instead of leaving a
stale changes list — while still no-oping on unrelated PRs that never
had a comment.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XbTDNRr7WgSWZAaLEYeSbm
@jonathanKingston
jonathanKingston force-pushed the claude/screenshot-matching-response-uwqw3d branch from 2be3536 to ce36f9a Compare July 14, 2026 11:14
@github-actions

Copy link
Copy Markdown
Contributor

Merge conflict needs a human

main advanced and screenshot conflicts were resolved automatically, but these non-screenshot files conflict and can't be auto-merged. Resolve them by hand (merge or rebase main):

  • .github/workflows/ci.yml

@jonathanKingston jonathanKingston added area:ci Continuous integration and test infrastructure enhancement New feature or request priority:p3 Normal-priority backlog work labels Jul 16, 2026 — with Cursor
# Conflicts:
#	.github/workflows/ci.yml
@jonathanKingston
jonathanKingston marked this pull request as ready for review July 18, 2026 14:55
@cursor

cursor Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_82f1db3a-6701-4d72-a185-8191023b01ad)

@jonathanKingston
jonathanKingston enabled auto-merge (squash) July 18, 2026 14:56
@cursor
cursor Bot requested a review from AutomatedTester July 18, 2026 14:58

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Not approving: Cursor Bugbot skipped (usage limit reached), so automated review did not complete. CI precheck is also failing on this sync. Human review is needed before merge; requested AutomatedTester as reviewer.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@cursor

cursor Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_728b7aba-9cc4-40da-a589-b75f17eb5115)

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not approving: Cursor Bugbot skipped (usage limit reached), so automated review did not complete. Human review is still needed before merge; AutomatedTester is already requested as reviewer.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@jonathanKingston
jonathanKingston merged commit ab58efa into main Jul 18, 2026
20 checks passed
@jonathanKingston
jonathanKingston deleted the claude/screenshot-matching-response-uwqw3d branch July 18, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ci Continuous integration and test infrastructure enhancement New feature or request priority:p3 Normal-priority backlog work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants