Skip to content

Add right-click Remove from sidebar for projects - #937

Merged
jonathanKingston merged 4 commits into
mainfrom
jkt/auto/remove-project-sidebar-ef2e
Jul 20, 2026
Merged

jonathanKingston merged 4 commits into
mainfrom
jkt/auto/remove-project-sidebar-ef2e

Conversation

@jonathanKingston

@jonathanKingston jonathanKingston commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Right-clicking a project row in the sidebar opens a context menu with Remove from sidebar
  • Removal only updates the app's project list / activeProjectId in config — it does not delete workspace files or thread-store data on disk
  • Removing the active project switches to another open project (or clears the workspace UI if it was the last one)

Visual eval

Context menu on Project B
After remove — only Project A remains

CI fix

e2e (3) failed with Electron Killed / invalid session id (OOM). Root cause: adding project-remove-sidebar.e2e.ts shifted WDIO --shard 3/3 boundaries so heavy project-switch-panels.e2e.ts moved onto shard 3. The new visual eval itself had already passed on shard 2. Renamed the spec to projects-remove-sidebar.e2e.ts so it sorts after project-switch-panels and restores the prior shard load.

Test plan

  • Unit tests for removeProject (inactive, active→switch, last project)
  • Component test: contextmenu opens menu; clicking remove drops the row
  • E2E: tests/e2e/projects-remove-sidebar.e2e.ts (menu + after screenshots)
  • npm test / focused e2e passed locally
  • CI e2e shards green after rename

To show artifacts inline, enable in settings.

Open in Web Open in Cursor 

@jonathanKingston
jonathanKingston marked this pull request as ready for review July 16, 2026 11:13
@cursor

cursor Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@jonathanKingston
jonathanKingston enabled auto-merge (squash) July 16, 2026 11:13
@cursor
cursor Bot force-pushed the jkt/auto/remove-project-sidebar-ef2e branch from 7d88728 to 5d57e6a Compare July 16, 2026 13:54
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Merge conflict needs a human

main advanced and screenshot conflicts were resolved automatically, but these non-screenshot files conflict and can't be auto-merged. Resolve them by hand (merge or rebase main):

  • docs/ui-taste.md
  • src/renderer/views/projects-pane.ts

@jonathanKingston

Copy link
Copy Markdown
Collaborator Author

Heads-up: this branch has merge conflicts with current main (post #991/#992/#999 CI fixes + roadmap changes). The e2e instability that was failing CI here is addressed on main — after resolving conflicts and updating, CI should be meaningfully greener. Conflicting areas: source files (not just screenshots), so resolving needs feature context.

cursoragent and others added 4 commits July 19, 2026 22:51
Projects can be dismissed from the sidebar via a context menu without
deleting workspace files or thread-store data on disk.

Co-authored-by: Jonathan Kingston <jonathanKingston@users.noreply.github.com>
Prove right-click Remove from sidebar in WDIO, commit reference shots,
and note the .context-menu pattern in ui-taste.

Co-authored-by: Jonathan Kingston <jonathanKingston@users.noreply.github.com>
Adding project-remove-sidebar.e2e.ts shifted WDIO shard boundaries so
project-switch-panels (heavy terminal scoping) moved onto shard 3 and
Electron was SIGKILL'd. Sort the new visual eval after that spec so
shard 2 keeps its previous load and shard 3 only gains a light test.

Co-authored-by: Jonathan Kingston <jonathanKingston@users.noreply.github.com>
@jonathanKingston
jonathanKingston force-pushed the jkt/auto/remove-project-sidebar-ef2e branch from 5d57e6a to 498d125 Compare July 19, 2026 21:55
@cursor

cursor Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_7300e902-3a35-4370-87dd-b5ad97c9a2dd)

@cursor
cursor Bot requested a review from AutomatedTester July 19, 2026 21:55

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not approving: Cursor Bugbot completed as skipped (usage limit), so automated review did not run. Human review is needed before merge; requested AutomatedTester.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@jonathanKingston
jonathanKingston merged commit b2de172 into main Jul 20, 2026
20 checks passed
@jonathanKingston
jonathanKingston deleted the jkt/auto/remove-project-sidebar-ef2e branch July 20, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants