You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Implements G3 from the hooks plan: vendored Claude SchemaStore + Cursor community hook schemas; warn-level authoring lint only; CI drift detector vs adapter-known events.
Screenshot conflicts with main are resolved automatically, but these non-screenshot files conflict and can't be auto-merged. Resolve them by hand (merge or rebase main) — the screenshot reconcile was skipped:
main advanced and screenshot conflicts were resolved automatically, but these non-screenshot files conflict and can't be auto-merged. Resolve them by hand (merge or rebase main):
Pin committed copies of the upstream hook-config JSON schemas under
schemas/vendor/ (Claude Code from SchemaStore; the community cursor-hooks
npm schema), with provenance + pins + re-vendoring steps in the vendor
README. Never remote-fetched at runtime or in CI — reads the committed
copies from disk only (.prettierignore keeps them byte-identical to
upstream).
Mirror each schema's published event list as TS constants in
src/shared/hooks/vendored-hook-schemas.ts with an explicit
intentionally-unsupported set per dialect. Extend the warn-level authoring
lint to the Claude adapter: a declared-but-unwired vendor event is skipped
WITH a warning (recognised-but-unsupported vs unknown/typo), surfaced via
listClaudeHooks (now HooksListResult) into hooks:list — never a load gate.
Add the CI drift detector (vendor-schema-drift.test.ts): offline, diffs
each vendored schema's published events against the adapter-wired events
and fails when intentionally-unsupported != published \ wired, so an
upstream release adding an unaccounted event forces a deliberate choice.
Mark G3 done in the plan; short pointer in docs/cursor-hooks.md.
Co-authored-by: Jonathan Kingston <jonathanKingston@users.noreply.github.com>
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Not approving: Cursor Bugbot completed as skipped (usage limit reached) and did not produce a clean review. Human review is needed before merge; requested AutomatedTester as reviewer.
Sent by Cursor Approval Agent: Pull Request Router and Approver
The reason will be displayed to describe this comment to others. Learn more.
Not approving: Cursor Bugbot completed as skipped and did not produce a clean review. Human review is still needed before merge; AutomatedTester is already requested as reviewer.
Sent by Cursor Approval Agent: Pull Request Router and Approver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jonathanKingston
added this to the
Post-GA product work milestone
ChatGPT Codex Connector
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![https://cursor.com/assets/images/open-in-web-dark.png"><source](https://cursor.com/assets/images/open-in-web-dark.png"><source){kind=link}
![https://cursor.com/assets/images/open-in-web-light.png"><img](https://cursor.com/assets/images/open-in-web-light.png"><img){kind=link}
![https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a](https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a){kind=link}
![https://cursor.com/assets/images/open-in-cursor-dark.png"><source](https://cursor.com/assets/images/open-in-cursor-dark.png"><source){kind=link}
![https://cursor.com/assets/images/open-in-cursor-light.png"><img](https://cursor.com/assets/images/open-in-cursor-light.png"><img){kind=link}
![https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div](https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div){kind=link}
Summary
Implements G3 from the hooks plan: vendored Claude SchemaStore + Cursor community hook schemas; warn-level authoring lint only; CI drift detector vs adapter-known events.
Stacked on #946 (G2) → #945 (G1) → … → #913 (A1).
Acceptance criteria (from plan G3 row)
Deliverables
schemas/vendor/with provenance READMEvendor-schema-drift.test.tsTests
npm run checkgreen (2965 tests)Test plan
npm run check