Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Avoid extra IDL generation during verify #3398

Conversation

acheroncrypto
Copy link
Collaborator

Problem

IDL is being generated twice inside the verify command:

  1. During the regular build process, which also includes building the IDL:

    build(

  2. Regular IDL generation:

    let local_idl = generate_idl(&cfg, true, false, &cargo_args)?;

We can avoid the first build operation by setting the no_idl argument of build to true.

Summary of changes

Avoid extra IDL generation inside the verify command.

Copy link

vercel bot commented Dec 1, 2024

@acheroncrypto is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@acheroncrypto acheroncrypto added cli fix Bug fix PR labels Dec 1, 2024
@acheroncrypto acheroncrypto merged commit 758ba84 into coral-xyz:master Dec 1, 2024
0 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli fix Bug fix PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant