Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance swap logic and refactor tests #3400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

techvoyagerX
Copy link

Description

This PR introduces enhancements and refactors to the swap logic and associated tests for improved clarity, maintainability, and functionality. Key changes include:

  • Account Setup Refactor: Modularized and reused account setup logic for both swap directions.
  • Fee Handling: Introduced a TAKER_FEE constant to centralize and simplify fee-related logic.
  • Balance Verification Helper: Added a withBalanceChange utility function to streamline and improve test readability.
  • Expanded Test Cases: Improved coverage for various swap scenarios:
    • Swapping between USDC and Token A.
    • Swapping between Token A and Token B (transitive swaps).
    • Added detailed assertions for balance changes and expected results.
  • Code Readability: Cleaned up inline comments and variable naming to enhance code clarity.

Copy link

vercel bot commented Dec 2, 2024

@techvoyagerX is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant