Feature/internal metrics improvments #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NimrodAvni78
force-pushed
the
feature/internal-metrics-improvments
branch
4 times, most recently
from
6579f0e to
9ddec74
Compare
mmat11
reviewed
Aug 18, 2025
mmat11
reviewed
Aug 18, 2025
mmat11
reviewed
Aug 18, 2025
mmat11
reviewed
Aug 18, 2025
mmat11
reviewed
Aug 18, 2025
mmat11
reviewed
Aug 18, 2025
pkg/components/imetrics/imetrics.go
Outdated
| BpfProbeLatency(probeID, probeType, probeName string, latencySeconds float64) | ||
| // BpfMapEntries is invoked every time a BPF map size is recorded | ||
| BpfMapEntries(mapID, mapName, mapType string, entriesTotal int) | ||
| // BpfMapMaxEntries is invoked every time a BPF map size is recorded |
There was a problem hiding this comment.
Suggested change
| // BpfMapMaxEntries is invoked every time a BPF map size is recorded | |
| // BpfMapMaxEntries is invoked every time a BPF map max size is recorded |
mmat11
reviewed
Aug 18, 2025
| "net" | ||
|
|
||
| "github.com/caarlos0/env/v7" | ||
| "google.golang.org/grpc" |
mmat11
reviewed
Aug 18, 2025
| "time" | ||
|
|
||
| "github.com/caarlos0/env/v7" | ||
|
|
mmat11
reviewed
Aug 18, 2025
| "time" | ||
|
|
||
| "github.com/caarlos0/env/v7" | ||
|
|
There was a problem hiding this comment.
Why is this happening everytime I didn't change that 😭
There was a problem hiding this comment.
maybe the IDE doesn't recognize the vanity url and it fails to sort properly 😂 - just guessing
NimrodAvni78
force-pushed
the
feature/internal-metrics-improvments
branch
4 times, most recently
from
1825203 to
14b6c43
Compare
NimrodAvni78
force-pushed
the
feature/internal-metrics-improvments
branch
from
be031fd to
3695505
Compare
NimrodAvni78
force-pushed
the
feature/internal-metrics-improvments
branch
from
3695505 to
63c9903
Compare
NimrodAvni78
force-pushed
the
feature/internal-metrics-improvments
branch
from
9f2613a to
7d40c91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add metrics for trace exports
add bpf metrics to internal metrics reporter