Hook up remaining DSA notifications #4391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shows that we can process these fields, translate, and format them nicely on the notification components stream side.
✅ Deploy Preview for gallant-galileo-14878c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kabeaty
reviewed
Nov 10, 2023
client/src/core/client/stream/tabs/Notifications/NotificationContainer.tsx
Outdated
Show resolved
Hide resolved
not just for when they're approved/rejected
…tions # Conflicts: # server/src/core/server/services/dsaReports/reports.ts # server/src/core/server/stacks/rejectComment.ts
useful for filtering and searching in mongo later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
None
Does this PR introduce any new environment variables or feature flags?
No
If any indexes were added, were they added to
INDEXES.md?No new indices.
How do I test this PR?
DSA Reporting:
General Approve/Reject of comments with reasons:
Where any tests migrated to React Testing Library?
No
How do we deploy this PR?
No special considerations, it goes into the DSA epic branch when complete.