Fix translations not working on commentModerationActions
when user accounts are deleted
#4427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There are two
common.ftl
files, one is server side, the other is in the shared library between theserver
and theclient
.This moves the
common-accountDeleted
into the server sideftl
so that it can be pulled by thei18n
bundles duirng the user deletion task.These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
None
Does this PR introduce any new environment variables or feature flags?
No
If any indexes were added, were they added to
INDEXES.md
?No new indices.
How do I test this PR?
common-accountDeleted
inserver/src/core/server/locales/en-US/common.ftl
to something obvious likeTHIS IS TRANSLATED
server/src/core/server/services/users/delete.ts
at the value ofUser account deleted
so you can see that the text is translatedcronTime
to"0,30 * * * * *"
(five*
's, not 4) inserver/src/core/server/cron/accountDeletion.ts
so that it runs twice a minutemulti-site-test
andnpm run development:withJobs
Admin > Config > General > DSA
with an admin/mod userAdmin > Config > Authentication > Commenter account management features
with an admin/mod userscheduledForDeletionDate
on that user to some time months agocommentModerationActions
where thedetailedExplanation
isTHIS IS TRANSLATED
to prove that the translation happened properly for the rejected/deleted commentsWhere any tests migrated to React Testing Library?
No
How do we deploy this PR?
No special considerations.