[CORL-2979]: Add custom reason field to Other rejection reason #4436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
marcushaddon
approved these changes
Nov 28, 2023
kabeaty
added
the
🚀 merge it!
kabeaty
deleted the
feat/CORL-2979-add-custom-reason-field-other-rejection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds a required
Custom reasontextbox to the rejection reason modal in the case that theOtherreason is selected. This supports rejecting comments for custom reasons.These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
This adds the
customReasonfield toRejectionReasonto support this.Does this PR introduce any new environment variables or feature flags?
no
If any indexes were added, were they added to
INDEXES.md?n/a
How do I test this PR?
You can go to a comment in the stream and reject it. Select the
Otherreason. See that there's now a requiredCustom reasonfield whenOtheris selected. Type a custom reason and click reject. See that the custom reason is saved. An additional explanation can also still be added. Other rejection reasons should still behave as before.Also see that the same changes are reflected in the admin for rejection reason modal.
Where any tests migrated to React Testing Library?
How do we deploy this PR?