Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setters of INBOUND_DATA_ERROR and OUTBOUND_DATA_ERROR #1078

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

M4tteoP
Copy link
Member

@M4tteoP M4tteoP commented Jun 10, 2024

As reported by #1045 (comment), not all the body limit reached checks were followed by setting the *_DATA_ERROR flag when the limit was reached

@M4tteoP M4tteoP requested a review from a team as a code owner June 10, 2024 21:28
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.07%. Comparing base (4ff1f76) to head (d3acc6a).
Report is 50 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1078      +/-   ##
==========================================
+ Coverage   82.72%   83.07%   +0.35%     
==========================================
  Files         162      164       +2     
  Lines        9080     7673    -1407     
==========================================
- Hits         7511     6374    -1137     
+ Misses       1319     1044     -275     
- Partials      250      255       +5     
Flag Coverage Δ
default 83.07% <100.00%> (+5.23%) ⬆️
examples 83.07% <100.00%> (+56.64%) ⬆️
ftw 83.07% <100.00%> (+35.70%) ⬆️
ftw-multiphase 83.07% <100.00%> (+33.52%) ⬆️
tinygo ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcchavezs jcchavezs added the v3.2 label Jun 13, 2024
@M4tteoP M4tteoP merged commit e42dcd5 into corazawaf:main Jun 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants