Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow selectors on *_NAMES collections #1143

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Merge branch 'main' into no-panic-on-non-selectable-col

41ca211
Select commit
Loading
Failed to load commit list.
Open

feat: allow selectors on *_NAMES collections #1143

Merge branch 'main' into no-panic-on-non-selectable-col
41ca211
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 21, 2025 in 0s

81.57% (-0.13%) compared to edad234

View this Pull Request on Codecov

81.57% (-0.13%) compared to edad234

Details

Codecov Report

Attention: Patch coverage is 59.37500% with 39 lines in your changes missing coverage. Please review.

Project coverage is 81.57%. Comparing base (edad234) to head (41ca211).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
internal/variables/variablesmap.gen.go 50.00% 26 Missing ⚠️
internal/corazawaf/transaction.go 8.33% 11 Missing ⚠️
internal/collections/named.go 93.10% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1143      +/-   ##
==========================================
- Coverage   81.69%   81.57%   -0.13%     
==========================================
  Files         169      169              
  Lines        9770     9855      +85     
==========================================
+ Hits         7982     8039      +57     
- Misses       1537     1565      +28     
  Partials      251      251

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov