Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retracts version 3.2.2 #1264

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix: retracts version 3.2.2 #1264

merged 1 commit into from
Jan 3, 2025

Conversation

jcchavezs
Copy link
Member

Thank you for contributing to Coraza WAF, your effort is greatly appreciated
Before submitting check if what you want to add to coraza list meets quality standards before sending pull request. Thanks!

Make sure that you've checked the boxes below before you submit PR:

Thanks for your contribution ❤️

@jcchavezs jcchavezs requested a review from a team as a code owner January 3, 2025 09:52
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.69%. Comparing base (edad234) to head (3695bf1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1264   +/-   ##
=======================================
  Coverage   81.69%   81.69%           
=======================================
  Files         169      169           
  Lines        9770     9770           
=======================================
  Hits         7982     7982           
  Misses       1537     1537           
  Partials      251      251           
Flag Coverage Δ
coraza.rule.case_sensitive_args_keys 81.65% <ø> (ø)
coraza.rule.multiphase_valuation 81.69% <ø> (ø)
coraza.rule.no_regex_multiline 81.63% <ø> (ø)
default 81.69% <ø> (ø)
examples+ 16.54% <ø> (ø)
examples+coraza.rule.case_sensitive_args_keys 81.65% <ø> (ø)
examples+coraza.rule.multiphase_valuation 81.53% <ø> (ø)
examples+coraza.rule.no_regex_multiline 81.55% <ø> (ø)
examples+memoize_builders 81.65% <ø> (ø)
examples+no_fs_access 80.98% <ø> (ø)
ftw 81.69% <ø> (ø)
memoize_builders 81.79% <ø> (ø)
no_fs_access 81.14% <ø> (ø)
tinygo 81.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@M4tteoP M4tteoP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3.2.2 tag was mistakenly created and removed shortly afterward, but it remains technically available and visible on pkg.go.dev. I agree with retracting it in favor of the newly released v3.3.0.

@jcchavezs jcchavezs merged commit 44c991b into main Jan 3, 2025
71 checks passed
@jcchavezs jcchavezs deleted the retract_3.2.2 branch January 3, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants