Trying to fix issue with enable/disable track through receivers/senders list with Janus Videoroom #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That was fast :) Did you test it ? |
@hthetiot Unfortunately I did only quick test with Janus Videoroom Demo wrapped to Cordova app. I plan test it more with our app but it will take some time to implement related feature there. |
|
@RSATom can you merge master pls. |
RSATom
force-pushed
the
master
branch
2 times, most recently
from
0052263 to
fea2057
Compare
|
@hthetiot done. |
|
Thx @RSATom |
|
@RSATom Can you confirm this solve non uniq UUID on track/stream support for Janus ? |
|
We are using this patch some time already - and it solve issue for us. |
|
Perfect, will QA and other libs and merge and release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #734