Skip to content

[ADD] a gitignore for simplifying git PR#147

Merged
MeowMJ merged 5 commits intocoredac:mainfrom
MeowMJ:main
Oct 16, 2025
Merged

[ADD] a gitignore for simplifying git PR#147
MeowMJ merged 5 commits intocoredac:mainfrom
MeowMJ:main

Conversation

@MeowMJ
Copy link
Copy Markdown
Collaborator

@MeowMJ MeowMJ commented Oct 8, 2025

Add a .gitignore for all. It ignores the listed things when you run git add .. Please add your personal things under #misc entry.

@MeowMJ MeowMJ requested review from ShangkunLi and tancheng October 8, 2025 12:34
n0thingNoob
n0thingNoob reviewed Oct 9, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@n0thingNoob n0thingNoob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this file?

@MeowMJ
Copy link
Copy Markdown
Collaborator Author

MeowMJ commented Oct 9, 2025 •
edited
Loading

Do we need this file?

If you use git add . to add your change, this file helps you to ignore intermidiate outputs like add.mlir.scrpit from your change. Like this https://github.com/tancheng/CGRA-Mapper/blob/master/.gitignore

@tancheng
Copy link
Copy Markdown
Contributor

tancheng commented Oct 9, 2025

Do we need this file?

You encountered this issue before, right? Tons of unrelated files are committed when I previously reviewed your PR?

@n0thingNoob
Copy link
Copy Markdown
Collaborator

n0thingNoob commented Oct 9, 2025

Do we need this file?

You encountered this issue before, right? Tons of unrelated files are committed when I previously reviewed your PR?

I remember there is one in @Jackcuii last PR, and your comment said do not check in that file, which makes me confused. I am not saying that we should not have this file, but just not sure.

@n0thingNoob n0thingNoob self-requested a review October 9, 2025 02:41
ShangkunLi
ShangkunLi reviewed Oct 9, 2025
View reviewed changes
@tancheng tancheng requested a review from ShangkunLi October 9, 2025 14:28
tancheng
tancheng reviewed Oct 16, 2025
View reviewed changes
@tancheng
Copy link
Copy Markdown
Contributor

tancheng commented Oct 16, 2025

Plz merge once the test passes, thanks @MeowMJ~!

@MeowMJ MeowMJ merged commit 67aed64 into coredac:main Oct 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tancheng tancheng tancheng approved these changes

@n0thingNoob n0thingNoob n0thingNoob approved these changes

@HobbitQia HobbitQia Awaiting requested review from HobbitQia

@ShangkunLi ShangkunLi Awaiting requested review from ShangkunLi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MeowMJ @tancheng @n0thingNoob @ShangkunLi