Skip to content

Explictly use promote-func-arg-to-constant pass #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShangkunLi merged 2 commits into from
Oct 15, 2025
Merged

Explictly use promote-func-arg-to-constant pass #155

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ee2415
explictly use promote-func-arg-to-constant
ShangkunLi Oct 14, 2025
a588170
enable fold-constant in conversion pipeline
ShangkunLi Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/NeuraDialect/NeuraPasses.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ void mlir::neura::registerNeuraConversionPassPipeline() {

pm.addPass(mlir::neura::createCanonicalizeCastPass());
pm.addPass(mlir::neura::createPromoteFuncArgToConstPass());
pm.addPass(mlir::neura::createFoldConstantPass());
pm.addPass(mlir::neura::createCanonicalizeLiveInPass());
pm.addPass(mlir::neura::createLeveragePredicatedValuePass());
pm.addPass(mlir::createPrintOpGraphPass(os));
Expand Down
2 changes: 1 addition & 1 deletion lib/NeuraDialect/Transforms/Optimizations/HwAgnosticOpt/FoldConstantPass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ struct FuseRhsConstantPattern : public OpRewritePattern<OpType> {
Value rhs = op.getRhs();

if (isOriginConstantOp(lhs)) {
assert(false && "LHS constant folding not implemented yet.");
llvm::errs() << "LHS constant folding not supported yet.\n";
return failure();
}

Expand Down