Support lhs constant folding for commutative ops#156
Merged
tancheng merged 4 commits intocoredac:mainfrom Oct 17, 2025
Merged
Conversation
tancheng
reviewed
Oct 15, 2025
lib/NeuraDialect/Transforms/Optimizations/HwAgnosticOpt/FoldConstantPass.cpp
Outdated
Show resolved
Hide resolved
lib/NeuraDialect/Transforms/Optimizations/HwAgnosticOpt/FoldConstantPass.cpp
Outdated
Show resolved
Hide resolved
Contributor
|
Can we have a simple test for this? |
Collaborator
|
Do we need to support directly get the result when lhs and rhs are both constant? |
Contributor
I believe there is existing pass can do such thing, e.g., |
Collaborator
Author
Sure, added in the latest commit. |
tancheng
approved these changes
Oct 16, 2025
lib/NeuraDialect/Transforms/Optimizations/HwAgnosticOpt/FoldConstantPass.cpp
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We support
lhsconstant folding for commutative ops likeadd,mul, etc.