Skip to content

Add empty testbench folder structure#158

Merged
n0thingNoob merged 3 commits intomainfrom
testbench_update
Oct 17, 2025
Merged

Add empty testbench folder structure#158
n0thingNoob merged 3 commits intomainfrom
testbench_update

Conversation

@n0thingNoob
Copy link
Copy Markdown
Collaborator

  • Create 8 testbench folders: Conv2D, dtw, FFT, fir, gemm, histogram, relu, SpMV
  • Use .gitkeep files to maintain empty folder structure
  • Prepare for adding testbench files in the future

- Create 8 testbench folders: Conv2D, dtw, FFT, fir, gemm, histogram, relu, SpMV
- Use .gitkeep files to maintain empty folder structure
- Prepare for adding testbench files in the future
@n0thingNoob n0thingNoob requested a review from Copilot October 17, 2025 00:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@n0thingNoob n0thingNoob requested a review from tancheng October 17, 2025 00:11
@tancheng
Copy link
Copy Markdown
Contributor

Can't we simply do git submodule add https://github.com/tancheng/CGRA-Bench ./test/.?

@tancheng
Copy link
Copy Markdown
Contributor

Can't we simply do git submodule add https://github.com/tancheng/CGRA-Bench ./test/.?

And I think your empty folders are also necessary/okay to be there, so later we can put test.mlir inside them.

@n0thingNoob
Copy link
Copy Markdown
Collaborator Author

git submodule add https://github.com/tancheng/CGRA-Bench ./test/.
I am a little bit confused. Do you mean place it like this?
test/
├── testbench/
│ ├── FFT/
│ ├── FIR/
│ └── GEMM/
└── CGRA-Bench/
or like this:
test/
├── testbench/
│ ├── FFT/
│ ├── FIR/
│ ├── GEMM/
│ └── CGRA-Bench/

@tancheng
Copy link
Copy Markdown
Contributor

first one LGTM~!

@n0thingNoob
Copy link
Copy Markdown
Collaborator Author

first one LGTM~!

ok

@n0thingNoob
Copy link
Copy Markdown
Collaborator Author

My bad, I was working on another branch, and I forgot to change it. I am trying to update the submodule and accidentally merge the architecture_spec branch to this one.
Can I just close it and recreated a new PR?

@tancheng
Copy link
Copy Markdown
Contributor

My bad, I was working on another branch, and I forgot to change it. I am trying to update the submodule and accidentally merge the architecture_spec branch to this one. Can I just close it and recreated a new PR?

I think you can

  • simply check out to branch of add support to max_ii #153
  • roll back to the second last commit
  • fix all issues then merge
  • Then in this PR, merge with tot, everything would be good then?

@tancheng
Copy link
Copy Markdown
Contributor

and also feel free to close this and make a new one, as this one is pretty tiny/simple

@n0thingNoob
Copy link
Copy Markdown
Collaborator Author

My bad, I was working on another branch, and I forgot to change it. I am trying to update the submodule and accidentally merge the architecture_spec branch to this one. Can I just close it and recreated a new PR?

I think you can

  • simply check out to branch of add support to max_ii #153
  • roll back to the second last commit
  • fix all issues then merge
  • Then in this PR, merge with tot, everything would be good then?

Yes, I am working on that.

- Add CGRA-Bench submodule to test/ directory
- Provides external benchmark collection for testing
- Maintains clean testbench folder structure
@n0thingNoob
Copy link
Copy Markdown
Collaborator Author

It should be good now.

@n0thingNoob n0thingNoob merged commit b390978 into main Oct 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants