Skip to content

Refactor FoldConstantPass with generic framework #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n0thingNoob merged 12 commits into from
Oct 25, 2025
Merged

Refactor FoldConstantPass with generic framework #176

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d209cce
Add LLVM to NEURA conversion for select and and operations
YanzhouTang Oct 23, 2025
788eff8
Refactor FoldConstantPass with generic framework and update test
YanzhouTang Oct 24, 2025
d43596b
Fix LoadIndexed/StoreIndexed constant folding to only fold base operand
YanzhouTang Oct 24, 2025
ff2b9cb
Fix block ordering bug in TransformCtrlToDataFlow pass using RPO trav…
YanzhouTang Oct 24, 2025
cc0c50d
Update testcases for TransformCtrlToDataFlow using RPO traversal
YanzhouTang Oct 24, 2025
76e8218
Unify neura.sel argument order to match llvm.select: (cond, ifTrue, i…
YanzhouTang Oct 25, 2025
ac8b2d1
Add periods to all comments in FoldConstantPass.cpp
YanzhouTang Oct 25, 2025
a91f041
Refactor OperandFoldingInfo from SoA to AoS pattern for better clarity
YanzhouTang Oct 25, 2025
3d9d071
Add comments to explain macro-generated pattern classes in FoldConsta…
YanzhouTang Oct 25, 2025
5e5e1b7
Refactor: use DEFINE_BINARY_OP_PATTERN macro for ICmp, FMax, FMin, an…
YanzhouTang Oct 25, 2025
bfd2ff3
Refactor: use third-person verb forms in comments
YanzhouTang Oct 25, 2025
967deca
Refactor: improve code comments and variable naming for better readab…
YanzhouTang Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions include/NeuraDialect/NeuraOps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,14 @@ def Neura_FMinOp : Op<NeuraDialect, "fmin"> {
}

// Defines a bitwise OR operation.
def Neura_AndOp : Op<NeuraDialect, "and"> {
let summary = "Bitwise AND operation";
let arguments = (ins AnyType:$lhs, AnyType:$rhs);
let results = (outs AnyType:$result);
// let assemblyFormat = "$lhs `,` $rhs `,` attr-dict `:` type($result)";
let traits = [SameOperandsAndResultElementType];
}

def Neura_OrOp : Op<NeuraDialect, "or"> {
let summary = "Bitwise OR operation";
let arguments = (ins AnyType:$lhs, AnyType:$rhs);
Expand Down
30 changes: 30 additions & 0 deletions lib/Conversion/LlvmToNeura/LlvmToNeuraPass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,17 @@ struct LlvmFSubToNeuraFSub : public OpRewritePattern<mlir::LLVM::FSubOp> {
}
};

struct LlvmAndToNeuraAnd : public OpRewritePattern<mlir::LLVM::AndOp> {
using OpRewritePattern::OpRewritePattern;

LogicalResult matchAndRewrite(mlir::LLVM::AndOp op,
PatternRewriter &rewriter) const override {
rewriter.replaceOpWithNewOp<neura::AndOp>(op, op.getType(), op.getLhs(),
op.getRhs());
return success();
}
};

struct LlvmOrToNeuraOr : public OpRewritePattern<mlir::LLVM::OrOp> {
using OpRewritePattern::OpRewritePattern;

Expand Down Expand Up @@ -243,6 +254,23 @@ struct LlvmFPToSIToNeuraCast : public OpRewritePattern<mlir::LLVM::FPToSIOp> {
}
};

struct LlvmSelectToNeuraSel : public OpRewritePattern<LLVM::SelectOp> {
using OpRewritePattern::OpRewritePattern;

LogicalResult matchAndRewrite(LLVM::SelectOp op,
PatternRewriter &rewriter) const override {
Value cond = op.getCondition();
Value true_value = op.getTrueValue();
Value false_value = op.getFalseValue();
Type result_type = op.getType();

// Note: neura.sel has different argument order: (ifTrue, ifFalse, cond)
rewriter.replaceOpWithNewOp<neura::SelOp>(op, result_type,
true_value, false_value, cond);
return success();
}
};

struct LlvmFMulAddToNeuraFMulFAdd : public OpRewritePattern<mlir::LLVM::FMulAddOp> {
using OpRewritePattern::OpRewritePattern;

Expand Down Expand Up @@ -723,6 +751,7 @@ struct LowerLlvmToNeuraPass
patterns.insert<LlvmVectorReduceAddToNeuraVectorReduceAdd>(&getContext());
// Scalar operations
patterns.add<LlvmAddToNeuraAdd>(&getContext());
patterns.add<LlvmAndToNeuraAnd>(&getContext());
patterns.add<LlvmOrToNeuraOr>(&getContext());
patterns.add<LlvmFAddToNeuraFAdd>(&getContext());
patterns.add<LlvmFMulToNeuraFMul>(&getContext());
Expand Down Expand Up @@ -752,6 +781,7 @@ struct LowerLlvmToNeuraPass
patterns.add<LlvmFDivToNeuraFDiv>(&getContext());
patterns.add<LlvmFPToSIToNeuraCast>(&getContext());
patterns.add<LlvmFMulAddToNeuraFMulFAdd>(&getContext());
patterns.add<LlvmSelectToNeuraSel>(&getContext());

FrozenRewritePatternSet frozen(std::move(patterns));

Expand Down
Loading