Conversation
Closed
tancheng
commented
May 28, 2025
yuqisun
approved these changes
Jun 10, 2025
ShangkunLi
reviewed
Jun 10, 2025
| def Neura_MovOp : NeuraBaseMov<"mov"> { | ||
| let summary = "Base move operation"; | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
What is the difference in functionalities between MovOp and DataMovOp
Contributor
Author
There was a problem hiding this comment.
DataMov is for data delivery while I also provide CtrlMov.
I initially plan to have both inherited from same base Op, however, failed due to some cmake or tablegen issue. And later I found I need CtrlMov to represent the backward flow. So in the latest commit in this PR, I just give two separate MovOp.
ShangkunLi
pushed a commit
that referenced
this pull request
Mar 12, 2026
Provide predicated data type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--leverage-predicated-value--leverage-predicated-value), we need to respect that, i.e., perform the computation and also set the predicate correctly/correspondingly--leverage-predicated-value), we just ignore the predicate-related stuff (i.e., set it astrueby default) @Yfeng-44TODO in next PR:
bbbut provide ctrl_mov with live-in analysis