Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the axpy kernel test by moving constant values (N=16, A=3) from function parameters into the kernel itself. This change reduces the complexity of the test setup by eliminating the need to handle parameter values through YAML output files.
Changes:
- Added a new bash script to sync e2e test outputs to the Zeonica_Testbench submodule
- Modified the axpy kernel to use hardcoded constants instead of parameters, reducing the function signature from 4 parameters to 2
- Updated the MLIR test expectations to reflect the new kernel signature and simplified compiled output (II reduced from 6 to 5)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/sync_e2e_outputs_to_zeonica_testbench.sh | New utility script to synchronize e2e test outputs (DFG, YAML, ASM files) to the Zeonica_Testbench submodule |
| test/benchmark/axpy/axpy_int.cpp | Simplified kernel signature by moving N and A constants into the function body |
| test/e2e/axpy/axpy_kernel.mlir | Updated test expectations to match new kernel signature with 2 parameters instead of 4, reflecting improved compilation metrics |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tancheng
approved these changes
Jan 26, 2026
tancheng
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original kernel emits arguments via the YAML output. To simplify testing, I slightly modified it by moving the constant values into the kernel.