[CI] Remove git submodule update --remote --recursive#257
Merged
BenkangPeng merged 1 commit intocoredac:mainfrom Jan 31, 2026
Merged
[CI] Remove git submodule update --remote --recursive#257BenkangPeng merged 1 commit intocoredac:mainfrom
git submodule update --remote --recursive#257BenkangPeng merged 1 commit intocoredac:mainfrom
Conversation
Collaborator
Author
|
And the redundant whitespaces and newlines are removed/formatted automatically by pre-commit. |
ShangkunLi
approved these changes
Jan 31, 2026
tancheng
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git submodule update --remote --recursiveis a dangerous command which will updates submodules to their latest state rather than the pinned/specified commits. This may introduce CI failures.The reason of CI failures of pr 247, 252, 254 is:
The relu test had been updated in submodule : tancheng/CGRA-Bench@ccc0f9f...2beecc5
But we didn't update the content that FileCheck needs: https://github.com/coredac/dataflow/blob/main/test/e2e/relu/relu_kernel.mlir