Skip to content

Fix run command syntax and check rules in nested_branch.mlir test#68

Merged
YanzhouTang merged 1 commit intocoredac:mainfrom
YanzhouTang:fix-nested-branch-test
Jul 9, 2025
Merged

Fix run command syntax and check rules in nested_branch.mlir test#68
YanzhouTang merged 1 commit intocoredac:mainfrom
YanzhouTang:fix-nested-branch-test

Conversation

@YanzhouTang
Copy link
Copy Markdown
Collaborator

@YanzhouTang YanzhouTang commented Jul 8, 2025

Description

The test was not properly validating output because the RUN command syntax was incorrect, causing it to falsely pass without actually running the transformation pipeline and FileCheck validation.

Changes Made

  1. Fix run command
  2. Update CHECK rules in nested_branch.mlir test

@YanzhouTang YanzhouTang requested a review from tancheng July 8, 2025 15:40
Copy link
Copy Markdown
Contributor

@tancheng tancheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix~!

@tancheng tancheng added the bug Something isn't working label Jul 8, 2025
@YanzhouTang YanzhouTang merged commit cc7f4a6 into coredac:main Jul 9, 2025
1 check passed
ShangkunLi pushed a commit that referenced this pull request Mar 12, 2026
Fix run command syntax and check rules in nested_branch.mlir test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants