Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions include/NeuraDialect/NeuraOps.td
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename loop_controller to loop_control? All the other operations are verb

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure~

Original file line number Diff line number Diff line change
Expand Up @@ -387,10 +387,11 @@ def Neura_LoopControllerOp : Op<NeuraDialect, "loop_controller">{
}];

let arguments = (ins
AnyType:$parent_valid, // Valid predicate from the parent loop
AnyType:$parentValid, // Valid predicate from the parent loop
AnyType:$start, // Start index of the loop
AnyType:$end, // End index of the loop
AnyType:$step // Step size for the loop
AnyType:$step, // Step size for the loop
StrAttr:$iterationType // Type of the loop iteration (e.g., "increment", "decrement")
);

let results = (outs
Expand All @@ -399,5 +400,5 @@ def Neura_LoopControllerOp : Op<NeuraDialect, "loop_controller">{
);

let assemblyFormat =
"$parent_valid `(` $start `,` $end `,` $step `)` attr-dict `:` type($parent_valid) `,` type($start) `,` type($end) `,` type($step) `->` type($index) `,` type($valid)";
" `(``parent_valid` `=` $parentValid `,` `start` `=` $start `,` `end` `=` $end `,` `step` `=` $step`)` attr-dict `:` type($parentValid) `,` type($start) `,` type($end) `,` type($step) `->` type($index) `,` type($valid)";
}
Loading