Merged
Conversation
tancheng
reviewed
Sep 12, 2025
Contributor
tancheng
left a comment
tancheng
left a comment
There was a problem hiding this comment.
Plz update your codegen README.md
Collaborator
Author
|
Sorry, I made a mistake, please ignore this version [d72a9d9] |
Collaborator
Author
|
@tancheng, is there anything else I need to modify? |
tancheng
approved these changes
Sep 12, 2025
Contributor
tancheng
left a comment
tancheng
left a comment
There was a problem hiding this comment.
Thanks for the refinement~! Plz smash the "ready for review" button (iirc), otherwise i am not aware of it is ready or not, thanks~!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The format has been revised. Whereas our YAML previously mapped one entry to one operation, it now adheres to the Entry → Instructions → Operations structure. Each core has only one entry for now (will be more entries in the future); each entry contains an ordered list of instructions. Every instruction is stamped by a timestep and contains one or more operations that execute in that timestep. Each operation specifies an opcode, src_operands, and dst_operands. For example: