Move the terminator to the end of BB#132
Merged
tancheng merged 1 commit intocoredac:mainfrom Sep 25, 2025
Merged
Conversation
tancheng
approved these changes
Sep 25, 2025
ShangkunLi
pushed a commit
that referenced
this pull request
Mar 12, 2026
Move the terminator to the end of BB
ShangkunLi
pushed a commit
that referenced
this pull request
Mar 12, 2026
Move the terminator to the end of BB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix the
returnproblem, we should not remove theTerminatorattribute ofreturnops. Because in a well-formed MLIR representation, each BB should terminate with a terminator.So I keep this attribute and explicitly reorder the ops so that
returnops will be put at the end of the flattened BB.