Minor Rails config update, with related tweaks #2436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Delete a few old config files: config/initializers/callback_terminator.rb config/initializers/new_framework_defaults.rb * Change JavaScript minifier (compressor) from uglifier to terser. Uglifier isn't as well-maintained and doesn't support many modern JS costructs. We'll still use one, because they make a big difference on slow networks. * Tweak to better use Claude Code. Do whitespace check *early* (that's a common mistake it makes), so we can fix those fast. Tell Claude to do `rake default` so we can auto-approve it. Document our application conventions to it. Signed-off-by: David A. Wheeler <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2436 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 57
Lines 2287 2287
=========================================
Hits 2287 2287 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete a few old config files: config/initializers/callback_terminator.rb config/initializers/new_framework_defaults.rb
Change JavaScript minifier (compressor) from uglifier to terser. Uglifier isn't as well-maintained and doesn't support many modern JS costructs. We'll still use one, because they make a big difference on slow networks.
Tweak to better use Claude Code. Do whitespace check early (that's a common mistake it makes), so we can fix those fast. Tell Claude to do
rake defaultso we can auto-approve it. Document our application conventions to it.