multi-arch-builders: extend AWS tofu bits to work for x86_64 or aarch64 #986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dustymabe
commented
May 4, 2024
dustymabe
commented
- Now depending on which directory you are in it will do the right thing.
- Handles RHCOS versus FCOS gracefully
- Deletes old provisioning instructions from the README
- Now depending on which directory you are in it will do the right thing. - Handles RHCOS versus FCOS gracefully - Deletes old provisioning instructions from the README
jlebon
approved these changes
May 27, 2024
There was a problem hiding this comment.
Does TF support includes? I feel like it might be clearer to rename this file, move it one level up and have the aarch64 and x86_64 bits just define the arch and include this one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.