Skip to content
This repository has been archived by the owner on Sep 22, 2020. It is now read-only.

Regenerate due to upstream changes #250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

braddeicide
Copy link

This change:
ugorji/go@54210f4

Causes this during build:
src/github.com/coreos/go-etcd/etcd/response.generated.go:242:27: too many arguments in call to r.Dec
have ([]byte, bool, bool)
want ([]byte, bool)
src/github.com/coreos/go-etcd/etcd/response.generated.go:261:28: too many arguments in call to r.Dec
have ([]byte, bool, bool)
want ([]byte, bool)
src/github.com/coreos/go-etcd/etcd/response.generated.go:326:26: too many arguments in call to r.Dec
have ([]byte, bool, bool)
want ([]byte, bool)
src/github.com/coreos/go-etcd/etcd/response.generated.go:572:27: too many arguments in call to r.Dec
have ([]byte, bool, bool)
want ([]byte, bool)
src/github.com/coreos/go-etcd/etcd/response.generated.go:1066:27: too many arguments in call to r.De
have ([]byte, bool, bool)
want ([]byte, bool)
src/github.com/coreos/go-etcd/etcd/response.generated.go:1379:14: cannot assign 1 values to 2 variab
src/github.com/coreos/go-etcd/etcd/response.generated.go:1494:21: cannot assign 1 values to 2 variab

I've regenerated response.generated.go and now it compiles. I did this to allow to compilation of gliderlabs/registrator: gliderlabs/registrator#591

@lucab
Copy link

lucab commented Sep 23, 2017

As the README says, this project has been deprecated since at least two years. If this is breaking any consumer, please migrate it to the official client instead.

@juliangamble
Copy link

This project is used by registrator. We'd like to make these changes - or at least add some doco for how to work around them.

@juliangamble
Copy link

I agree that this is the better solution. If there is a desire for "minimal change" then the polite thing to do is to help your users with a workaround. Please see the pull request here: #251

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants