activation: allow building without tls support #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When listeners.go APIs are not used by a given application, golang doesn't automatically optimize them out. Add an opt-out build tag to activation/listeners.go, such that one can build an application that uses activation files without the listeners APIs. For applications that do not already include any "crypto/tls" this can be highly beneficial, for example runc can reduce it's total binary size by 7.6%. runc project already uses go mod vendor, and can just delete the listeners.go file: - opencontainers/runc#5056 But it would be preffered if this opt-out build-tag was available here upstream for people to use in general.
Luap99
reviewed
Dec 5, 2025
Collaborator
Luap99
left a comment
Luap99
left a comment
There was a problem hiding this comment.
I am fine with a build tag, but the listeners_test.go should use the same tag so it doesn't fail with the tag.
And I guess it would be nice to documented that tag in the Readme so all library users are aware.
cc @kolyshkin
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| //go:build !no_listeners |
Collaborator
There was a problem hiding this comment.
go build tags are not namespaced so there is always risk that it could conflict when another project uses the same name.
As such I would prefer something more like go_systemd_no_listeners or even coreos_go_systemd_no_listeners
Collaborator
|
Looks like something in the fedora CI tests broke, we need to look into that. Otherwise I guess it would also be nice to add a CI test to make sure the build tag compiles correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When listeners.go APIs are not used by a given application, golang
doesn't automatically optimize them out. Add an opt-out build tag to
activation/listeners.go, such that one can build an application that
uses activation files without the listeners APIs.
For applications that do not already include any "crypto/tls" this can
be highly beneficial, for example runc can reduce it's total binary
size by 7.6%.
runc project already uses go mod vendor, and can just delete the listeners.go file:
But it would be preffered if this opt-out build-tag was available here
upstream for people to use in general.