Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to Go 1.22 #111

Merged
merged 1 commit into from
Feb 18, 2024
Merged

feat: update to Go 1.22 #111

merged 1 commit into from
Feb 18, 2024

Conversation

theseion
Copy link
Collaborator

@theseion theseion commented Feb 17, 2024

Go 1.22 includes improved printing of regular expression flags.

See golang/go#57950
See https://go-review.googlesource.com/c/go/+/507015

@theseion theseion force-pushed the go-1.22-update branch 3 times, most recently from b71aec4 to 7e45c3a Compare February 17, 2024 19:53
@theseion theseion marked this pull request as ready for review February 18, 2024 07:08
@theseion theseion requested a review from fzipi February 18, 2024 07:08
@theseion
Copy link
Collaborator Author

Note that the toolchain will generate slightly different expressions for character classes (no unnecessary ranges). I've also had to change the way we handle flags, as regexp/syntax now creates wrapping flag groups (?m:...) where it used to create context flag expressions (?m). Essentially, it is no longer possible to use flags inside of an expression, only with the flag comment ##!+. Since we've never done that anyway it's not an issue.

Go 1.22 includes improved printing of regular expression flags in
regexp/syntax.

See golang/go#57950
See https://go-review.googlesource.com/c/go/+/507015
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, optimization!

@theseion theseion merged commit 46fba6a into main Feb 18, 2024
5 checks passed
@theseion theseion deleted the go-1.22-update branch February 18, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants