Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: release automation #198

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: release automation #198

wants to merge 3 commits into from

Conversation

theseion
Copy link
Collaborator

@theseion theseion commented Jan 1, 2025

Fixes #140

@theseion
Copy link
Collaborator Author

theseion commented Jan 1, 2025

@fzipi This is a draft for release automation. Currently implemnted:

  1. create new branch for release
  2. update version and copyright
  3. create commit
  4. push branch
  5. create PR

The remote operations are not covered by unit tests but I've tested them a bit manually. I'm sure that stuff will fail but my idea was to use this version to create the release PR for the upcoming release and fix issues as we see them.

@theseion theseion force-pushed the release-automation branch 3 times, most recently from 550555e to 220a758 Compare January 3, 2025 09:47
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a mix of exec.Command git and also git v5 library usage. Can we consolidate in one of the methods?

chore/release/release.go Outdated Show resolved Hide resolved
chore/release/release.go Outdated Show resolved Hide resolved
chore/release/release.go Outdated Show resolved Hide resolved
chore/release/release.go Outdated Show resolved Hide resolved
chore/release/release.go Outdated Show resolved Hide resolved
@fzipi fzipi changed the title Release automation feat: release automation Jan 3, 2025
@theseion
Copy link
Collaborator Author

theseion commented Jan 3, 2025

I see a mix of exec.Command git and also git v5 library usage. Can we consolidate in one of the methods?

That's on purpose. The CLI takes care of all the complicated stuff like commit signing etc., while accessing information is simpler through go-git, as I don't have to parse the information (well, apart from figuring out the remote, which I should probably use go-git for as well).

@theseion theseion force-pushed the release-automation branch 3 times, most recently from 9b4d78f to c3d3a93 Compare January 4, 2025 09:34
@theseion theseion force-pushed the release-automation branch from c3d3a93 to 9b11c56 Compare January 4, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: create new release command
2 participants