Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change to absolute path #110

Merged
merged 2 commits into from
Feb 12, 2024
Merged

fix: change to absolute path #110

merged 2 commits into from
Feb 12, 2024

Conversation

fzipi
Copy link
Member

@fzipi fzipi commented Feb 12, 2024

Fixes #99.

@fzipi
fix: change to absolute path
15d463f 
Signed-off-by: Felipe Zipitria <[email protected]>
@fzipi fzipi requested review from azurit and RedXanadu February 12, 2024 13:19
@azurit
Copy link
Member

azurit commented Feb 12, 2024 •
edited
Loading

@fzipi Are you sure this fixes the problem? If i understand it right, the final URL will be https://coreruleset.org/data/IdNumbering.csv which still doesn't work. URL should be https://coreruleset.org/docs/data/IdNumbering.csv.

@fzipi
fix: update relative resource
ae01de9 
Signed-off-by: Felipe Zipitria <[email protected]>
@fzipi
Copy link
Member Author

fzipi commented Feb 12, 2024

Ok, this will fix it. Tested for both environments (test, and prod)

@fzipi fzipi merged commit 3d19754 into main Feb 12, 2024
1 check passed
@fzipi fzipi deleted the fix-idnumbering-link branch February 12, 2024 20:35
@dune73
Copy link
Member

dune73 commented Feb 13, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azurit azurit Awaiting requested review from azurit

@RedXanadu RedXanadu Awaiting requested review from RedXanadu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing file IdNumbering.csv
3 participants
@fzipi @azurit @dune73