Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework AWS WAF section #98

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Rework AWS WAF section #98

merged 1 commit into from
Jun 15, 2023

Conversation

RedXanadu
Copy link
Member

PR reworks the AWS WAF section, as we no longer believe that the AWS WAF "core rule set" is related to the actual OWASP CRS.

Resolves issue #97

@RedXanadu
Copy link
Member Author

RedXanadu commented Jun 15, 2023

@dune73 Do you think this wording is okay?

It displays like so, in a "Note" block:

image

@dune73
Copy link
Member

dune73 commented Jun 15, 2023

That looks good. Thank you.

@dune73 dune73 merged commit f79d983 into main Jun 15, 2023
@RedXanadu RedXanadu deleted the rework_aws_waf_crs_section branch June 15, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants