chatterbox(): add tune_gc opt-out for CUDA GC tuning#22
Merged
Conversation
The CUDA GC tuning added in 0.1.0.15 (.set_cuda_gc_options) is a persistent options() side effect. Expose it as a documented tune_gc parameter (default TRUE) so callers can opt out with tune_gc = FALSE; the Details section documents the side effect. No behavior change at the default. Bumps to 0.1.0.16.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the CUDA GC tuning merged in #21 (0.1.0.15).
That tuning (
.set_cuda_gc_options) sets persistent session-globaltorch.*options — deliberately, since torch reads the allocator rates later at CUDA init. The CRAN cookbook flags persistentoptions()changes, so this exposes the behavior as an opt-out instead of an unconditional side effect:chatterbox()gainstune_gc = TRUE. Passtune_gc = FALSEto skip the tuning.@detailsdocuments the persistent side effect, the only-if-unset behavior, and the CUDA-only gating.No behavior change at the default. This is the Option A approach (documented param) we discussed for chatterbox; whisper went with the fully opt-in
whisper_tune_gc()function (cornball-ai/whisper#10).Version 0.1.0.15 -> 0.1.0.16.