Fix win-builder test crash in beam search#5
Merged
Conversation
…tests
The KV cache tests checked requireNamespace("torch") but not
torch::torch_is_installed(), so they crashed on win-builder where
torch is installed but lantern/libtorch binaries are missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
torch::torch_is_installed()guard to KV cache tests intest_beam_search.RrequireNamespace("torch")alone returns TRUE on win-builder even when lantern/libtorch binaries are missing, causing a crash on the firsttorch_randn()callTest plan