automatticlly add keyscript to crypttab #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thuandt
added a commit
to thuandt/yubikey-luks
that referenced
this pull request
Jun 21, 2019
cornelinux
requested changes
Oct 24, 2020
| @@ -93,4 +93,21 @@ else | |||
| if [ "$DBG" = "1" ]; then echo "LUKS key: $R"; fi | |||
| fi | |||
|
|
|||
| # add keyscript to /etc/crypttab | |||
|
|
|||
| if [[ -b ${DISK} ]] | |||
There was a problem hiding this comment.
If there are several yubikeys connected to a machine I would not like to update the initramfs each time a yubikey is added. So we should use a command line parameter here. Like
-u update initramfs config
| eval $( grep ${DISK} /etc/crypttab | awk '{ print $2 }' ) | ||
| fi | ||
|
|
||
| if ! grep 'keyscript=/usr/share/yubikey-luks/ykluks-keyscript' /etc/crypttab |
There was a problem hiding this comment.
Please use square brackets here, to have a consistent code style.
Also: I think we should only match for "keyscript"; so that we do not add a 2nd keyscript if another keyscript was already configured!
|
|
||
| if ! grep 'keyscript=/usr/share/yubikey-luks/ykluks-keyscript' /etc/crypttab | ||
| then | ||
| sed -i "/${UUID}/ s/$/,keyscript=\/usr\/share\/yubikey-luks\/ykluks-keyscript/" /etc/crypttab |
There was a problem hiding this comment.
Unfortunately this breaks for me. I think this is not very robust. Even in another shell (bash), this starts to break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically add keyscript to crypttab when enrolling if the keyscript is not already set.